Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version function so that it returns Postgres version #484

Merged
merged 2 commits into from
Jul 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions server/functions/init.go
Original file line number Diff line number Diff line change
Expand Up @@ -94,5 +94,6 @@ func Init() {
initTrimScale()
initTrunc()
initUpper()
initVersion()
initWidthBucket()
}
41 changes: 41 additions & 0 deletions server/functions/version.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
// Copyright 2024 Dolthub, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package functions

import (
"fmt"

"github.com/dolthub/go-mysql-server/sql"

"github.com/dolthub/doltgresql/server/functions/framework"
pgtypes "github.com/dolthub/doltgresql/server/types"
)

const postgresVersion = "15.5"

// initVersion registers the functions to the catalog.
func initVersion() {
framework.RegisterFunction(version)
}

// version represents the PostgreSQL system information function of the same name, taking no parameters.
var version = framework.Function0{
Name: "version",
Return: pgtypes.Text,
Strict: true,
Callable: func(ctx *sql.Context) (any, error) {
return fmt.Sprintf("PostgreSQL %s", postgresVersion), nil
},
}
11 changes: 11 additions & 0 deletions testing/go/functions_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -321,5 +321,16 @@ func TestSystemInformationFunctions(t *testing.T) {
},
},
},
{
Name: "version",
Assertions: []ScriptTestAssertion{
{
Query: `SELECT version();`,
Expected: []sql.Row{
{"PostgreSQL 15.5"},
},
},
},
},
})
}