Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version function so that it returns Postgres version #484

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Fix version function so that it returns Postgres version #484

merged 2 commits into from
Jul 9, 2024

Conversation

tbantle22
Copy link
Contributor

@tbantle22 tbantle22 commented Jul 8, 2024 •
edited
Loading

Relies on GMS PR: dolthub/go-mysql-server#2588

@tbantle22 tbantle22 changed the title Attempt to fix version func Attempt to fix version func Jul 8, 2024
@tbantle22 tbantle22 changed the title Attempt to fix version func Fix version function so that it returns Postgres version Jul 9, 2024
@tbantle22 tbantle22 marked this pull request as ready for review July 9, 2024 22:56
Hydrocharged
Hydrocharged approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tbantle22 tbantle22 merged commit 5d01c40 into main Jul 9, 2024
9 checks passed
@tbantle22 tbantle22 deleted the taylor/version branch July 9, 2024 23:14
@BrewTestBot BrewTestBot mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbantle22 @Hydrocharged