-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parallax layout with new arch enabled #716
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
It works, thanks! |
Glad to see this. SDK 52 will allow enable New Arch in all Expo projects |
Expo SDK 52 was finally released. This library breaks the app when scrolling using parallax. Seems like this PR is fixing the problem. |
This also fixes my error. Please merge asap! |
I would really appreciate if the recent fixes (regarding the SDK 52 expo) would be merged ASAP |
@dohooo please merge this. |
It would help if this is merged soon. |
@dohooo please merge this. |
Hello guys, tests are given some trouble. I'll be testing out and see if I can possible merge it. |
@dohooo Thank you for the merge! Do you have any estimate of when it will be available in the npm package? |
I am still facing this problem. have tried the latest version on npm, the canary versions 19,20,21,22, but all seems to throw the same error. And this happens only when I use mode='horizontal-stack', <Carousel
ref={ref}
loop
pagingEnabled={true}
snapEnabled
width={width}
height={width / 2}
// mode='horizontal-stack'. <<== this line throws the error if enabled.
// modeConfig={{
// snapDirection: "left",
// stackInterval: 18,
// }}
// customConfig={() => ({ type: "positive", viewCount: 5 })}
autoPlay
data={data}
scrollAnimationDuration={5000}
// onSnapToItem={(index) => console.log('current index:', index)}
renderItem={({ index, item }) => (
<ThemedView
key={index}
style={{
flex: 1,
margin: 5,
borderRadius: 10,
elevation: 5
}}>
<Image style={{ flex: 1, borderRadius: 10, }} source={{ uri: item.imageUri }} />
</ThemedView>
)}
/>
|
This PR fixes #715, #712
Description
Round the zIndex value in the parallax layout
Review
Testing