Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parallax layout with new arch enabled #716

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Conversation

jiroscripts
Copy link
Contributor

@jiroscripts jiroscripts commented Nov 5, 2024

This PR fixes #715, #712

Description

Round the zIndex value in the parallax layout

Review

  • I self-reviewed this PR

Testing

  • I manually tested

Copy link

changeset-bot bot commented Nov 5, 2024

⚠️ No Changeset found

Latest commit: f153990

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 5, 2024
Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-reanimated-carousel ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2024 6:36am

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 5, 2024
@sntg-p
Copy link

sntg-p commented Nov 7, 2024

It works, thanks!

@BrodaNoel
Copy link
Contributor

Glad to see this.
Considering that Expo will release SDK 52 in few days/hours, every New Arch fix is very welcomed.

SDK 52 will allow enable New Arch in all Expo projects

@BrodaNoel
Copy link
Contributor

Expo SDK 52 was finally released.

This library breaks the app when scrolling using parallax. Seems like this PR is fixing the problem.
It will be better to have it merge as soon as possible. This library is blocking all new releases of any app using this library

@Davidnr24
Copy link

This also fixes my error. Please merge asap!

@aliunco
Copy link

aliunco commented Nov 21, 2024

I would really appreciate if the recent fixes (regarding the SDK 52 expo) would be merged ASAP

@FelipeBohnertPaetzold
Copy link

@dohooo please merge this.

@sanjitchh
Copy link

It would help if this is merged soon.

@anapaulaods
Copy link

@dohooo please merge this.

@oliverloops
Copy link
Collaborator

Hello guys, tests are given some trouble. I'll be testing out and see if I can possible merge it.
Thanks for your patience!

@oliverloops oliverloops enabled auto-merge (squash) November 21, 2024 18:11
@oliverloops oliverloops requested a review from dohooo November 21, 2024 18:15
@dohooo dohooo disabled auto-merge November 23, 2024 06:48
@dohooo dohooo merged commit 99cf31a into dohooo:main Nov 23, 2024
1 of 2 checks passed
@FelipeBohnertPaetzold
Copy link

@dohooo Thank you for the merge! Do you have any estimate of when it will be available in the npm package?

@dae54
Copy link

dae54 commented Dec 18, 2024

I am still facing this problem. have tried the latest version on npm, the canary versions 19,20,21,22, but all seems to throw the same error.
I have new arch enabled and using expo.

And this happens only when I use mode='horizontal-stack',

 <Carousel
        ref={ref}
        loop
        pagingEnabled={true}
        snapEnabled
        width={width}
        height={width / 2}
        // mode='horizontal-stack'.   <<== this line throws the error if enabled.
        // modeConfig={{
       // 	snapDirection: "left",
	// 	stackInterval: 18,
	// }}
        // customConfig={() => ({ type: "positive", viewCount: 5 })}
        autoPlay
        data={data}
        scrollAnimationDuration={5000}
        // onSnapToItem={(index) => console.log('current index:', index)}
        renderItem={({ index, item }) => (
          <ThemedView
            key={index}
            style={{
              flex: 1,
              margin: 5,
              borderRadius: 10,
              elevation: 5
            }}>
            <Image style={{ flex: 1, borderRadius: 10, }} source={{ uri: item.imageUri }} />
          </ThemedView>
        )}
      />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet