Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android][v4.0.0-canary.17] Carousel crashes the app #712

Closed
Bekaxp opened this issue Nov 3, 2024 · 13 comments
Closed

[Android][v4.0.0-canary.17] Carousel crashes the app #712

Bekaxp opened this issue Nov 3, 2024 · 13 comments
Assignees
Labels
bug Something isn't working

Comments

@Bekaxp
Copy link

Bekaxp commented Nov 3, 2024

Describe the bug
On Android when the user tries to scroll the carousel the app crashes and closes itself. Inspecting with Android Studio gives this error (top of the error stack):

java.lang.RuntimeException: Loss of precision during arithmetic conversion: (long) 388.7273063659668
at com.swmansion.reanimated.NativeProxy.performOperations(Native Method)

Maybe is even a bug with the react-native-reanimated, but I tried several versions and I always get the same results.

To Reproduce
Steps to reproduce the behavior:

  1. Create a simple Carousel component:
import Carousel from 'react-native-reanimated-carousel';
import {View} from 'react-native';

export function CarouselView() {
  return (
    <View style={{flex: 1}}>
      <Carousel
        ref={ref}
        width={width}
        height={height * 0.8}
        data={[1, 2, 3]}
        mode="parallax"
        modeConfig={{
          parallaxScrollingScale: 0.9,
          parallaxScrollingOffset: 70,
        }}
        pagingEnabled={true}
        snapEnabled={true}
        vertical={false}
        renderItem={({item, index}) => <View index={index}>{item}</View>}
      />
    </View>
  );
};
  1. Render it on an Android device/emulator
  2. Try to scroll left/right
  3. App crashes

Expected behavior
The Android app should not crash and the Carousel should scroll.

Versions (please complete the following information):

  • react: v18.3.1
  • react-native: v0.76.1
  • react-native-reanimated: v3.16.1
  • react-native-reanimated-carousel: v4.0.0-canary.17
  • react-native-gesture-handler: v2.20.2

Smartphone (please complete the following information):

  • Device: Pixel 9 [emulator]

Additional context

  • Using the Canary version of react-native-reanimated-carousel
@Bekaxp Bekaxp added the bug Something isn't working label Nov 3, 2024
Copy link

dosubot bot commented Nov 3, 2024

Hey @Bekaxp! I'm here to help you with any issues you're experiencing. I can assist you in solving bugs, answering questions, and becoming a contributor.

A similar issue regarding a "Loss of precision during arithmetic conversion" error has been reported and resolved. The suggested solution involves ensuring that arithmetic operations involving floating-point numbers are correctly handled before casting to a long. You can use Math.round in JavaScript to avoid precision loss. Here's an example:

const value = 388.7273063659668;
const longValue = Math.round(value); // Use Math.round to avoid precision loss

Additionally, ensure your babel.config.js includes the react-native-reanimated/plugin:

module.exports = function(api) {
  api.cache(true);
  return {
    presets: ['babel-preset-expo'],
    plugins: ['react-native-reanimated/plugin'],
  };
};

Make sure your project is using compatible versions of the dependencies:

"dependencies": {
  "react": "18.3.1",
  "react-native": "0.76.1",
  "react-native-reanimated": "3.16.1",
  "react-native-reanimated-carousel": "4.0.0-canary.17",
  "react-native-gesture-handler": "2.20.2"
}

These steps should help resolve the issue and ensure compatibility [1].

To continue talking to Dosu, mention @dosu.

@Bekaxp
Copy link
Author

Bekaxp commented Nov 3, 2024

Thank you

but as you can see in my simple example I am not doing any conversions of any sort. I guess this is done internally in the lib to calculate the positioning?

Cheers

@Medkhat
Copy link

Medkhat commented Nov 8, 2024

Hi there! "react-native-reanimated-carousel": "^3.5.1" also has this issue

@Yusang-park
Copy link

Yusang-park commented Nov 9, 2024

I upgraded to 4.0.0~canary-17 and no issue was found.
but I needed to modify the custom animation.

previous

const parallelX = (value: number) => {
  'worklet';

  const zIndex = interpolate(value, [-1, 0, 1], [10, 20, 30]);
  const scale = interpolate(value, [-2, -1, 0, 1, 2], [0.7, 0.8, 1, 0.8, 0.7]);
  const opacity = interpolate(value, [-0.75, 0, 1], [0, 1, 0]);
  const translateX = interpolate(value, [-1, 0, 1], [-PAGE_WIDTH * 0.5, 0, PAGE_WIDTH]);
  return {
    transform: [{ translateX }, { scale }],
    zIndex,
    opacity,
  };
};

new

const parallelX = (value: number) => {
  'worklet';

  const zIndex = Math.round(interpolate(value, [-1, 0, 1], [10, 20, 30]));
  const scale = interpolate(value, [-1, 0, 1], [0.8, 1, 0.8]);
  const opacity = interpolate(value, [-1, 0, 1], [0, 1, 0]);
  const translateX = Math.round(interpolate(value, [-1, 0, 1], [-PAGE_WIDTH * 0.3, 0, PAGE_WIDTH * 0.3]));

  return {
    transform: [{ translateX }, { scale }] as const,
    zIndex,
    opacity,
  };
};

Trying to add Math.***

@Medkhat
Copy link

Medkhat commented Nov 10, 2024

@Yusang-park Did you test it on Android? I don't have any custom animation:

<Carousel
      autoPlay
      autoPlayInterval={4000}
      data={data as Banner[]}
      width={FULL_WIDTH_CONTENT}
      height={BANNER_HEIGHT}
      loop={true}
      pagingEnabled={true}
      snapEnabled={true}
      mode="parallax"
      modeConfig={{
        parallaxScrollingScale: 0.9,
        parallaxScrollingOffset: 50,
      }}
      // mode="horizontal-stack"
      // modeConfig={{
      //   showLength: 1,
      // }}
      renderItem={renderItem}
  />

@Bekaxp
Copy link
Author

Bekaxp commented Nov 10, 2024

Have a look at the discussion in #715 . There is also a PR open to fix this. I tried with the patch from @thibaultcapelli and it worked. So I will happily wait for the PR to be merged and a new canary version to be released 👍 . Thanks.

@mamicrose
Copy link

Replace the zIndex variable in node_modules/react-native-reanimated-carousel/src/layouts/parallax.ts

with this:

const zIndex = Math.round(interpolate(value, [-1, 0, 1], [0, size, 0]));

image

@hieutrantrong21520859MMCL21

Hi everyone, I have encountered with the same problem for "stack" animation. Does anyone have a solution? Thanks.

Version:

  • react: v18.3.1
  • react-native: v0.76.2
  • react-native-reanimated: v3.16.1
  • react-native-reanimated-carousel: v3.5.1
  • react-native-gesture-handler: v2.20.2

@SunartoSun
Copy link

SunartoSun commented Dec 4, 2024

Have a look at the discussion in #715 . There is also a PR open to fix this. I tried with the patch from @thibaultcapelli and it worked. So I will happily wait for the PR to be merged and a new canary version to be released 👍 . Thanks.

May i know which patch is this?
Can i have the link?
How do i patch it?

@Bekaxp
Copy link
Author

Bekaxp commented Dec 4, 2024

Hi @SunartoSun, I think the simplest way now would be to use "react-native-reanimated-carousel": "4.0.0-canary.22". I think it already includes the fix... try it out. :)

Otherwise... this was the PR with the fix => #716

And you can apply patches easily with yarn => https://yarnpkg.com/features/patching (if you use yarn...) :)

@Bekaxp Bekaxp closed this as completed Dec 4, 2024
@Ronstein
Copy link

Replace the zIndex variable in node_modules/react-native-reanimated-carousel/src/layouts/parallax.ts

with this:

const zIndex = Math.round(interpolate(value, [-1, 0, 1], [0, size, 0]));

image

This fix works for me. I expect resolved this issue for the future

@Living-Tribunal
Copy link

Replace the zIndex variable in node_modules/react-native-reanimated-carousel/src/layouts/parallax.ts

with this:

const zIndex = Math.round(interpolate(value, [-1, 0, 1], [0, size, 0]));

image

Thank you, this worked!

@rousseau634
Copy link

Hi everyone, I have encountered with the same problem for "stack" animation. Does anyone have a solution? Thanks.

Version:

  • react: v18.3.1
  • react-native: v0.76.2
  • react-native-reanimated: v3.16.1
  • react-native-reanimated-carousel: v3.5.1
  • react-native-gesture-handler: v2.20.2

I am facing the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

10 participants