Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color code thumbs up/down on hover in evaluation #3725

Merged
merged 3 commits into from
Jun 28, 2022

Conversation

BTWS2
Copy link
Contributor

@BTWS2 BTWS2 commented Jun 17, 2022

I closed #3484 accidentally.

My goal with this approach is to add a visual confirmation the teacher pressed the right button.

Changing the color property in both states wasn't possible without javascript. This is the proposal using pure CSS: small color change on hover and clicking shows more green/red for clear visual feedback. When the teacher hovers over the wrong button, a glimpse of the wrong color is shown.

he end of the animation is cut off at the end, because the button is updated when the loading is done (visible at the end of the screen recording of dark mode below). I made the animation shorter and used ease-out to mitigate this partly. I added a space before the brackets and added a newline at the end.

At first I chose a lighter color ($danger-100), but it resulted in even more harsh colors in dark mode (e.g. $danger-100: $red-800 !global;), so I used opacity instead.

Light mode:

2022-04-02-21-01-25.mp4

Dark mode:

2022-04-02-21-02-11.mp4

Closes #2715.

@BTWS2 BTWS2 requested a review from a team as a code owner June 17, 2022 15:56
@BTWS2 BTWS2 requested review from bmesuere and niknetniko and removed request for a team June 17, 2022 15:56
@chvp chvp added the enhancement A change that isn't substantial enough to be called a feature label Jun 27, 2022
@bmesuere bmesuere merged commit e1d7238 into dodona-edu:develop Jun 28, 2022
@bmesuere
Copy link
Member

thanks, @BTWS2 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A change that isn't substantial enough to be called a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch order of thumbs up/down buttons in grading panel
4 participants