-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color code thumbs up/down on hover in evaluation #3484
Conversation
My goal with this approach is to add a visual confirmation the teacher pressed the right button. This shows the color after pressing the button. When the teacher hovers over the wrong button, a glimpse of the wrong color is shown with the previous approach. I agree with @jorg-vr that changing the color of the icon looks cleaner. It's based on https://css-tricks.com/different-transitions-for-hover-on-hover-off/. 2022-03-17-23-26-21.mp4 |
Why not combine both behaviours? Color on mouse over + a slight delay after clicking? |
@bmesuere A color change on mouse over (without animation) and visual feedback after clicking would indeed be better. If I had to choose I prefer the visual feedback after clicking, but both is better. |
Changing the Light mode: 2022-03-23-19-17-54.mp4Dark mode: 2022-03-23-20-45-31.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The background color is still quite harsh, I think. The end of the animation also looks a little strange to me. Maybe a fade-out would make it less jarring?
I changed the background to lighter shade of the color. The end of the animation is cut off at the end, because the button is updated when the loading is done (visible at the end of the screen recording of dark mode below). I made the animation shorter and used At first I chose a lighter color ( Light mode: 2022-04-02-21-01-25.mp4Dark mode: 2022-04-02-21-02-11.mp4 |
This pull request closes #2715.
I don't have strong opinions on the order of thumbs up or down, but I'm in favor of color coding (thumbs up = green, thumbs down = red) to nudge towards the correct button as @rien suggested. I can switch the order if needed:
https://github.com/dodona-edu/dodona/blob/develop/app/views/feedbacks/_feedback_actions.html.erb
https://github.com/dodona-edu/dodona/blob/develop/app/views/feedbacks/_score_actions.html.erb