Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix babel 'loose' warning #3276

Merged
merged 2 commits into from
Jan 6, 2022
Merged

Fix babel 'loose' warning #3276

merged 2 commits into from
Jan 6, 2022

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Jan 6, 2022

This pull request explicitly adds @babel/plugin-proposal-private-property-in-object to babel.config.js
We already used it implicitly.

Adding it explicitly allows us to specify the loose: true setting. Again this setting was already used because other babel plugins had this setting.
It solves the warning following warning:

Though the "loose" option was set to "false" in your @babel/preset-env config, it will not be used for @babel/plugin-proposal-private-property-in-object since the "loose" mode option was set to "true" for @babel/plugin-proposal-private-methods.
The "loose" option must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding
        ["@babel/plugin-proposal-private-property-in-object", { "loose": true }]
to the "plugins" section of your Babel config.

Closes #3142 .

@jorg-vr jorg-vr requested a review from a team as a code owner January 6, 2022 09:15
@jorg-vr jorg-vr requested review from bmesuere and chvp and removed request for a team January 6, 2022 09:15
@niknetniko niknetniko added the chore Repository/build/dependency maintenance label Jan 6, 2022
@bmesuere bmesuere merged commit d4c22f9 into develop Jan 6, 2022
@bmesuere bmesuere deleted the fix/3142-deprecation branch January 6, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Repository/build/dependency maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix deprecation warnings when building assets
3 participants