Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warnings when building assets #3142

Closed
bmesuere opened this issue Oct 2, 2021 · 2 comments · Fixed by #3276
Closed

Fix deprecation warnings when building assets #3142

bmesuere opened this issue Oct 2, 2021 · 2 comments · Fixed by #3276
Assignees
@jorg-vr
Labels
chore Repository/build/dependency maintenance medium priority Things we want to see implemented relatively soon student Things summer interns can do

Comments

@bmesuere
Copy link
Member

bmesuere commented Oct 2, 2021

The asset compilation generates a long list of deprecation warnings from sass. Recently, Babel joined the club and thousands of log lines are generated.
@bmesuere bmesuere added student Things summer interns can do chore Repository/build/dependency maintenance medium priority Things we want to see implemented relatively soon labels Oct 2, 2021
@jorg-vr jorg-vr mentioned this issue Jan 6, 2022
Merged
@jorg-vr
Copy link
Contributor

jorg-vr commented Jan 6, 2022

I remember getting the sass deprecation warnings as well, but can't seem to reproduce them.
Could you provide reproduction steps?
Or maybe these where fixed by #3272

@jorg-vr jorg-vr self-assigned this Jan 6, 2022
@bmesuere
Copy link
Member Author

bmesuere commented Jan 6, 2022

They were about variables not being assigned at the top level and that this would break in future versions. However, they were assigned at the top level so maybe this is fixed by renaming the imports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorg-vr jorg-vr

Labels
chore Repository/build/dependency maintenance medium priority Things we want to see implemented relatively soon student Things summer interns can do
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix babel 'loose' warning dodona-edu/dodona
2 participants
@bmesuere @jorg-vr