Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve color scheme of diff highlighting in dark mode #2950

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Improve color scheme of diff highlighting in dark mode #2950

merged 1 commit into from
Aug 3, 2021

Conversation

TimonDB
Copy link
Contributor

@TimonDB TimonDB commented Aug 3, 2021 •
edited
Loading

This pull request adapts the colours in dark mode that highlight the feedback diff. It should now be more clear where the mistakes in the output occur.

Before:
Screenshot from 2021-08-03 11-29-08

After:
Screenshot from 2021-08-03 11-29-54

Closes #2420 .

@TimonDB TimonDB requested a review from a team as a code owner August 3, 2021 09:36
@TimonDB TimonDB requested review from bmesuere and chvp and removed request for a team August 3, 2021 09:36
@bmesuere bmesuere merged commit f2e8eb0 into develop Aug 3, 2021
@bmesuere bmesuere deleted the fix/improve-color-scheme-diff-highlighting branch August 3, 2021 09:55
@chvp chvp added the enhancement A change that isn't substantial enough to be called a feature label Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chvp chvp chvp approved these changes

@bmesuere bmesuere bmesuere approved these changes

Assignees
No one assigned
Labels
enhancement A change that isn't substantial enough to be called a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve color scheme of diff highlighting in dark mode
3 participants
@TimonDB @bmesuere @chvp