Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve color scheme of diff highlighting in dark mode #2420

Closed
pdawyndt opened this issue Dec 7, 2020 · 0 comments · Fixed by #2950
Closed

Improve color scheme of diff highlighting in dark mode #2420

pdawyndt opened this issue Dec 7, 2020 · 0 comments · Fixed by #2950
Assignees
@TimonDB
Labels
enhancement A change that isn't substantial enough to be called a feature low priority Thing we want to see implemented at some point student Things summer interns can do

Comments

@pdawyndt
Copy link
Contributor

pdawyndt commented Dec 7, 2020

In light mode it's immediately clear that there's an extra space at the end of the string

image

but this is less clear in dark mode

image

Example: submission

@bmesuere bmesuere added student Things summer interns can do low priority Thing we want to see implemented at some point labels Apr 12, 2021
@chvp chvp added the feature New feature or request label Jun 5, 2021
@TimonDB TimonDB mentioned this issue Aug 3, 2021
Merged
@niknetniko niknetniko added enhancement A change that isn't substantial enough to be called a feature and removed feature New feature or request labels Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimonDB TimonDB

Labels
enhancement A change that isn't substantial enough to be called a feature low priority Thing we want to see implemented at some point student Things summer interns can do
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve color scheme of diff highlighting in dark mode dodona-edu/dodona
5 participants
@bmesuere @niknetniko @pdawyndt @chvp @TimonDB