Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the deprecated Named (Native) Queries in Metadata/EntityRepository #9428

Merged
merged 2 commits into from
Jan 30, 2022

Conversation

sir-kain
Copy link
Contributor

Following this issue, I'm removing the deprecated Named (Native) Queries in Metadata/EntityRepository

@sir-kain sir-kain marked this pull request as draft January 26, 2022 15:45
@greg0ire
Copy link
Member

Please add an entry in UPGRADE.md to let the world know you have removed named queries. Also, there are docs that need to be removed:

rg -i 'named.*quer' docs
docs/en/reference/annotations-reference.rst
67:-  :ref:`@NamedNativeQuery <annref_named_native_query>`
882:.. _annref_named_native_query:
884:@NamedNativeQuery
889:    Named Native Queries are deprecated as of version 2.9 and will be removed in ORM 3.0
891:Is used to specify a native SQL named query.
892:The NamedNativeQuery annotation can be applied to an entity or mapped superclass.
912:     * @NamedNativeQueries({
913:     *      @NamedNativeQuery(
1186:     * @NamedNativeQueries({
1187:     *      @NamedNativeQuery(
1192:     *      @NamedNativeQuery(

docs/en/reference/php-mapping.rst
88:-   ``addNamedQuery($name, $dqlQuery)``

docs/en/reference/native-sql.rst
435:Named Native Query
440:    Named Native Queries are deprecated as of version 2.9 and will be removed in ORM 3.0
442:You can also map a native query using a named native query mapping.
445:using named native query (and sql resultset mappings if is a several resultset mappings).
447:Like named query, a named native query can be defined at class level or in an XML file.
450:A resultSetMapping parameter is defined in @NamedNativeQuery,
460:         * @NamedNativeQueries({
461:         *      @NamedNativeQuery(
521:                <named-native-queries>
522:                    <named-native-query name="fetchMultipleJoinsEntityResults" result-set-mapping="mappingMultipleJoinsEntityResults">
524:                    </named-native-query>
525:                </named-native-queries>
555:the ``fetchJoinedAddress`` named query use the joinMapping result set mapping.
568:             * @NamedNativeQueries({
569:             *      @NamedNativeQuery(
607:                <named-native-queries>
608:                    <named-native-query name="findAll" result-set-mapping="mappingFindAll">
610:                    </named-native-query>
611:                </named-native-queries>
636:             * @NamedNativeQueries({
637:             *      @NamedNativeQuery(
687:                <named-native-queries>
688:                    <named-native-query name="fetchJoinedAddress" result-set-mapping="mappingJoinedAddress">
690:                    </named-native-query>
691:                </named-native-queries>
718:             * @NamedNativeQueries({
719:             *      @NamedNativeQuery(
735:                <named-native-queries>
736:                    <named-native-query name="find-by-id" result-class="Address">
738:                    </named-native-query>
739:                </named-native-queries>
755:             * @NamedNativeQueries({
756:             *      @NamedNativeQuery(
782:                <named-native-query name="count" result-set-mapping="mappingCount">
784:                </named-native-query>

@sir-kain sir-kain changed the title Removed createNamedQuery function and made test pass Removing the deprecated Named (Native) Queries in Metadata/EntityRepository Jan 26, 2022
@derrabus derrabus marked this pull request as ready for review January 27, 2022 21:26
psalm-baseline.xml Outdated Show resolved Hide resolved
This feature has been deprecated.
@sir-kain sir-kain force-pushed the remove-deprecations branch from 81cc418 to 762885e Compare January 27, 2022 22:23
@greg0ire greg0ire merged commit 31b7d78 into doctrine:3.0.x Jan 30, 2022
@greg0ire
Copy link
Member

Thanks @sir-kain !

@greg0ire greg0ire added this to the 3.0.0 milestone Jan 30, 2022
@sir-kain sir-kain deleted the remove-deprecations branch January 30, 2022 19:19
@sir-kain sir-kain restored the remove-deprecations branch February 1, 2022 21:11
@sir-kain sir-kain deleted the remove-deprecations branch February 1, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants