Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-8592] Deprecated Named (Native) Queries in Metadata/EntityRepository #8593

Merged
merged 2 commits into from
Apr 5, 2021
Merged

[GH-8592] Deprecated Named (Native) Queries in Metadata/EntityRepository #8593

merged 2 commits into from
Apr 5, 2021

Conversation

beberlei
Copy link
Member

@beberlei beberlei commented Apr 5, 2021

Fixes #8592

This deprecates named (native) queries in two locations:

  • In metadata, so that its caught when defined but not used at runtime. Since metadata is cached, the runtime deprecation only happens in the first, uncached request.
  • In EntityRepository, because this would allow regular runtime deprecation to trigger and also shows up in user code (via IDE or Static Analysis).

@beberlei beberlei merged commit f8fa0fe into doctrine:2.9.x Apr 5, 2021
@beberlei beberlei deleted the DeprecateNamedQueries branch April 5, 2021 19:59
@sir-kain sir-kain mentioned this pull request Jan 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@guilhermeblanco guilhermeblanco Awaiting requested review from guilhermeblanco

Assignees
No one assigned
Labels
Deprecation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beberlei @greg0ire