doctrine/dbal v3 - Make sure that values passed to are not null #8889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! My first PR here.
Partially fixes #8884 - 7 out of 117 issues.
Let's start from fixing 2 types of issues:
The first issue is simpler -
modifyLimitQuery
has default$offset
value set to0
- so let's pass it instead ofnull
.For
AbstractPlatform::appendLockHint
there is no default value, so passingLockMode::NONE
seems to be the best choice - it would not affect any known implementation.