-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get Psalm job to pass with DBAL 3 #8884
Comments
One of the loudest issue are changes introduced in doctrine/dbal@5d03f6e - it affects |
Maybe re-declaring the property in the ORM class would solve the issue. Switching to a dedicated property per config value in the ORM class is a separate thing IMO, it can be done fully independently I think. |
…l to meet changes in doctrine/dbal v3. Fix psalm issues with type: `PossiblyNullArgument`, found after updating doctrine/dbal to v3. Override `null` passed as offset with `0` in calls to `Doctrine\DBAL\Platforms\AbstractPlatform::modifyLimitQuery`. Override `null` passed as lockMode with `LockMode::NONE` in calls to `Doctrine\DBAL\Platforms\AbstractPlatform::appendLockHint`. Partialy fixes doctrine#8884
The last type of errors seems to be connected with things that has been deprecated in |
Do you have an example? |
Sure. orm/lib/Doctrine/ORM/Id/UuidGenerator.php Line 36 in f3e55fa
There is no internal replacement for this method - just suggested to use ramsey/uuid instead. I can try to split it by case and create separate PRs for each issue :) |
Oh right, I even deprecated this in #8813 . If we want to have DBAL v3 with ORM v2, then I think we should indeed throw an exception letting people know they need to run
That would be a great approach 👍 |
…een removed in doctrine/dbal:3.x To keep backward compatibility we need to redeclare this property to keep using it. Partially fixes doctrine#8884
…een removed in doctrine/dbal:3.x To keep backward compatibility we need to redeclare this property to keep using it. Partially fixes doctrine#8884
…een removed in doctrine/dbal:3.x To keep backward compatibility we need to redeclare this property to keep using it. Partially fixes doctrine#8884
…ine/dbal:3.x. Generating `getGuidExpression` has been removed in doctrine/dbal:3.x. Partially fixes doctrine#8884
…ine/dbal:3.x. Generating `getGuidExpression` has been removed in doctrine/dbal:3.x. Partially fixes doctrine#8884
…ine/dbal:3.x. Generating `getGuidExpression` has been removed in doctrine/dbal:3.x. Partially fixes doctrine#8884
…n DBAL 3.x. Partially fixes doctrine#8884
…n DBAL 3.x. Partially fixes doctrine#8884
…ine/dbal:3.x. Generating `getGuidExpression` has been removed in doctrine/dbal:3.x. Partially fixes doctrine#8884
…ine/dbal:3.x. Generating `getGuidExpression` has been removed in doctrine/dbal:3.x. Partially fixes doctrine#8884
…n DBAL 3.x. Partially fixes doctrine#8884
…ine/dbal:3.x. Generating `getGuidExpression` has been removed in doctrine/dbal:3.x. Partially fixes doctrine#8884
…ine/dbal:3.x. Generating `getGuidExpression` has been removed in doctrine/dbal:3.x. Partially fixes doctrine#8884
…ine/dbal:3.x. Generating `getGuidExpression` has been removed in doctrine/dbal:3.x. Partially fixes doctrine#8884
…ine/dbal:3.x. Generating `getGuidExpression` has been removed in doctrine/dbal:3.x. Partially fixes doctrine#8884
Recently, a CI job was added on the 2.10.x branch to statically analyze this project after forcing the installation of
doctrine/dbal
v3.In order not to disrupt contributors, we made sure it would not fail the build although it really does not pass at all:
orm/.github/workflows/static-analysis.yml
Line 94 in e09f126
If you want to help us fix it or get closer to fixing it, you can reproduce the failures locally by running (from the 2.10.x branch)
When this issue is fixed, we should create a new one about making this job no longer experimental.
The text was updated successfully, but these errors were encountered: