Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt ignore rules to new version of PHPStan #8821

Merged
merged 2 commits into from
Jul 5, 2021

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Jul 5, 2021

No description provided.

@beberlei
Copy link
Member

beberlei commented Jul 5, 2021

@greg0ire what happened here though, is phpstan not pinned to an exact version?

@greg0ire
Copy link
Member Author

greg0ire commented Jul 5, 2021

It isn't and according to the history, has never been? I'm confused…

We want to control upgrades to avoid suddenly failing builds.
@greg0ire
Copy link
Member Author

greg0ire commented Jul 5, 2021

Ah I think we did it only for Psalm. Pushed a new commit.

@greg0ire greg0ire merged commit aa3ed91 into doctrine:2.9.x Jul 5, 2021
@greg0ire greg0ire deleted the fix-phpstan branch July 5, 2021 08:02
@greg0ire greg0ire restored the fix-phpstan branch July 5, 2021 08:02
@greg0ire greg0ire deleted the fix-phpstan branch July 5, 2021 08:02
@greg0ire greg0ire added this to the 2.9.4 milestone Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants