Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-8818] Deprecate entity namespace short aliases. #8820

Merged
merged 3 commits into from
Aug 5, 2021
Merged

[GH-8818] Deprecate entity namespace short aliases. #8820

merged 3 commits into from
Aug 5, 2021

Conversation

beberlei
Copy link
Member

@beberlei beberlei commented Jul 4, 2021

This PR deprecates entity namespace short aliases as advertised in issue.

Fixes #8818

@beberlei beberlei added this to the 2.10.0 milestone Jul 4, 2021
@greg0ire
Copy link
Member

greg0ire commented Jul 5, 2021

Blocked by #8821

@greg0ire greg0ire closed this Jul 5, 2021
@greg0ire greg0ire reopened this Jul 5, 2021
@greg0ire
Copy link
Member

greg0ire commented Jul 5, 2021

Let's document this in UPGRADE.md? Also, the wrong branch is being targeted here.

@VincentLanglet VincentLanglet mentioned this pull request Aug 1, 2021
Merged
@beberlei beberlei force-pushed the GH-8818-EntityNamespaceAliasDeprecation branch from 8b0d43b to e5228ba Compare August 4, 2021 20:26
@beberlei beberlei changed the base branch from 2.9.x to 2.10.x August 4, 2021 20:26
SenseException
SenseException requested changes Aug 4, 2021
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/doctrine/orm/blob/2.10.x/docs/en/reference/dql-doctrine-query-language.rst#terminals

AFAIK this seems the only occurrance of an alias in the docs. I think removing the last trails of aliases should be done with the deprecation.

@greg0ire greg0ire merged commit 12705b5 into doctrine:2.10.x Aug 5, 2021
@greg0ire
Copy link
Member

greg0ire commented Aug 5, 2021

Thanks @beberlei !

@github-actions github-actions bot mentioned this pull request Oct 3, 2021
Merged
@greg0ire greg0ire mentioned this pull request Mar 20, 2022
Merged
@ashishbhandariadesso ashishbhandariadesso mentioned this pull request Nov 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

Assignees
No one assigned
Labels
Deprecation
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

Deprecate Foo:Bar entity short syntax
3 participants
@beberlei @greg0ire @SenseException