Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues/7686 #7702

Closed
wants to merge 871 commits into from
Closed

Fix issues/7686 #7702

wants to merge 871 commits into from

Conversation

wajdijurry
Copy link

In this pull request, I did the following:
Fixing issue 7686

  • No tests required
  • I have read the contribution guidelines carefully.

Ocramius and others added 30 commits March 4, 2018 13:24
Update Scrutinizer config to use our CS setup
…n-tests

Tests: Return types for setUp, tearDown and all test methods
Documentation about getters/setters to DTOs and Value Objects
…in-getting-started

Removing leftover sentence in `getting-started.rst`
It's redundant to check the `$this->cacheable` property.
Redundant condition to check if a query is cacheable
Fix getting started syntax issue causing rendering glitches
Ocramius and others added 26 commits January 3, 2019 17:28
[3.0] Migrate repository name doctrine/doctrine2 -> doctrine/orm
…mmutable-version

Allow all datetime types to be used as version
Change Stackoverflow tag to doctrine-orm
Remove codeigniter Framework example (master)
Update information and links of documentation (master)
This method never return `null`.
`AbstractQuery::getSingleScalarResult()` never conditionally returns `null`: corrected docblock accordingly
[3.0] CI: Test against PHP 7.4snapshot instead of nightly (8.0)
Failing tests for #7926 - `scheduledForSynchronization` leaks memory when using `@ORM\ChangeTrackingPolicy("DEFERRED_EXPLICIT")
Add missing types to property mapping documentation
Remove full stops in docblocks
Annotation fix in example block
@wajdijurry
Copy link
Author

This PR required rebase, so it is closed.

@wajdijurry wajdijurry closed this May 7, 2019
@greg0ire
Copy link
Member

greg0ire commented May 7, 2019

Looks like you started from one branch but targeted another one. Note that you do not need to close a PR to fix things. You can change the target branch, and you can force push to your branch to make it right.

@wajdijurry wajdijurry deleted the fix-issues/7686 branch May 7, 2019 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.