Some fixes from PHPStan l2

[carusogabriel]

I found an interesting one for our CS with this PR:

- /* @var Class $variable */
+ /** @var Class $variable */

/cc @Majkl578 @kukulich

[Ocramius]

Yeah, phpstan set the standard for inline IDE hints there (before, /* and */ were to be used (see also https://netbeans.org/bugzilla/show_bug.cgi?id=267470)

[kukulich]

Hmm, there's already SlevomatCodingStandard.Commenting.InlineDocCommentDeclaration for the format of inline PHPDoc but it looks it should also check /*.

[Majkl578]

I don't really think /* ... */ was ever supposed to be a phpDoc block. Correct is /** ... */ : https://docs.phpdoc.org/guides/docblocks.html#anatomy-of-a-docblock

[Majkl578]

Can we enable L2 on Travis too now?

[Majkl578]

This bump looks unrelated.

[carusogabriel]

Should I revert it?

Hate have .lock versioned, always do that 😅

[Ocramius]

Yes please: .lock should not be randomly changed, or else we don't know why build-related deps crash our builds.

[Majkl578]

Probably, yes.
You can use the following to ignore any changes to composer.lock:

$ git update-index --assume-unchanged composer.lock

Then even if you run composer update and update dependencies, git will ignore that. ;)

To revert & track changes:

$ git update-index --no-assume-unchanged composer.lock

[carusogabriel]

@Ocramius @Majkl578 I'm learning more and more about Git every single day with you, thanks ❤️

I have reverted these changes, should be RTM :)

[carusogabriel]

@Majkl578 No, there're many errors to be fixed for l2 😢

Feedback handled

[Ocramius]

👍