NewObjectExpression: Allows use of nested new operators

[fesor]

Covers #4687, #6573

This PR adds ability to use aggregation of DTOs as query result:

$dql = '
    SELECT
        new UserDTO(
           u.id,
           u.name,
           new AddressDTO(
                address.country,
                address.city,
                address.street,
                address.postcode
           )
        )
    FROM User u
    JOIN u.location address
';

Use cases:

• reporting and aggregations results
• read-only queries

[fesor]

Needs test case (probably when new object is given as not last argument)

[fesor]

Looks like scrutinizer doesn't know how to deal with destructuring.

[lcobucci]

@fesor looks like this patch is going in a nice way, however I wonder that we should rather do this on v3 instead. Not sure about what @guilhermeblanco and @Ocramius think about this, but I believe it's about time to do a feature freeze on 2.x.

[Ocramius]

This will unlikely land in 2.x due to the current pressure to get 2.6 out and start with 3.x overall. I'd say we leave it as-is and ask for a rebase once `develop` is merged.

…

On 29 Oct 2017 23:25, "Luís Cobucci" ***@***.***> wrote: @fesor <https://github.com/fesor> looks like this patch is going in a nice way, however I wonder that we should rather do this on v3 instead. Not sure about what @guilhermeblanco <https://github.com/guilhermeblanco> and @Ocramius <https://github.com/ocramius> think about this, but I believe it's about time to do a feature freeze on 2.x. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6709 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJakOj_7hEEihbrvsxdX8SKYpEs6UGSks5sxPtugaJpZM4PceAv> .

[fesor]

@Ocramius rebased on master.

[tkleinhakisa]

Very nice! Does it handle collections ? eg if User has multiple addresses and constructor param is an array in UserDTO

[fesor]

@tkleinhakisa you mean handling *-to-many relations? Currently no... need to check how many changes in hydrator is required to make it possible.

I think that whole hydration system should be refactored so this and many other use cases could be possible without huge overhead, like the one in #2553 for example. But in order to make things both maintainable and performant, this would require some kind of inlining functionality and code generation...

[Majkl578]

I'd probably suggest to postpone further work here for now if it requires further redesign. 2.x branch is in feature-freeze and for 3.0 we've been discussing a full DQL parser rewrite. No roadmap for that yet, but I've already been prepping a switch to Hoa\Compiler.

[joshhornby]

What are the chances of this making it into v3?

[Majkl578]

It's definitely something I'd like to pursue since I believe DTOs have high potential, but likely not before rewriting the parser itself, for that see #7017.

[derrabus]

I'm closing this PR because it hasn't seen progress for several years. Please open a new one if you want to pick up the work one day.

[norkunas]

Hoa packages are abandoned. Could this be reconsidered?

[greg0ire]

Please open a new one if you want to pick up the work one day.