Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Add tests for introduction #2664

Merged
merged 1 commit into from
Jul 1, 2024
Merged

doc: Add tests for introduction #2664

merged 1 commit into from
Jul 1, 2024

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Jul 1, 2024

Q A
Type doc
BC Break yes/no
Fixed issues -

Summary

  • Add tests
  • Remove explicit field types, to rely on prop types.

@GromNaN GromNaN requested a review from alcaeus July 1, 2024 09:39
alcaeus
alcaeus approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but PhpStan doesn't like the readonly identifier.

@GromNaN GromNaN enabled auto-merge (squash) July 1, 2024 13:44
@GromNaN GromNaN merged commit 5082751 into doctrine:2.9.x Jul 1, 2024
17 of 18 checks passed
@GromNaN GromNaN added this to the 2.9.0 milestone Jul 1, 2024
alcaeus added a commit that referenced this pull request Sep 6, 2024
@alcaeus
Merge branch '2.9.x' into 2.8.x-merge-up-into-2.9.x_gy9cDuHl
6dffe12 
* 2.9.x: (24 commits)
  Fix typo in code example (#2670)
  Label PRs about GH actions with "CI" (#2632)
  Review basic mapping (#2668)
  Fix wording (#2667)
  Add native type to private properties and final classes (#2666)
  Review and add tests on `ResolveTargetDocumentListener` (#2660)
  Remove soft-delete-cookbook (#2657)
  doc: Remove wakeup and clone cookbook (#2663)
  Modernize generated code for Hydrators (#2665)
  Add tests for introduction (#2664)
  doc: Review mapping ORM and ODM cookbook (#2658)
  doc: Review cookbook on blending ORM and ODM (#2656)
  doc: Review and test validation cookbook (#2662)
  Update custom mapping example (#2654)
  doc: Review Simple Search Engine Cookbook (#2659)
  doc: Add cookbook about embedding referenced documents using $lookup (#2655)
  doc: Add type to properties (#2652)
  doc: Review custom collections and repository docs (#2653)
  doc: Review Getting Started (#2650)
  Move annotations-reference to attributes-reference (#2651)
  ...
@github-actions github-actions bot mentioned this pull request Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@GromNaN @alcaeus