doc: Remove wakeup and clone cookbook #2663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IonBazan
approved these changes
Jun 30, 2024
malarzm
reviewed
Jun 30, 2024
docs/en/reference/architecture.rst
Outdated
| - A document class must not implement ``__wakeup`` or | ||
| :doc:`do so safely <../cookbook/implementing-wakeup-or-clone>`. | ||
| Also consider implementing | ||
| - A document class must not implement ``__clone``. |
There was a problem hiding this comment.
Is this still true given we're using ProxyManager?
There was a problem hiding this comment.
Excellent question, I'll have to test that. I'd like to know in which cases it causes a problem.
There was a problem hiding this comment.
Removed this restrictions from the doc. I didn't find any issue with clone or wakeup.
SenseException
approved these changes
Jun 30, 2024
alcaeus
added a commit
that referenced
this pull request
Sep 6, 2024
* 2.9.x: (24 commits) Fix typo in code example (#2670) Label PRs about GH actions with "CI" (#2632) Review basic mapping (#2668) Fix wording (#2667) Add native type to private properties and final classes (#2666) Review and add tests on `ResolveTargetDocumentListener` (#2660) Remove soft-delete-cookbook (#2657) doc: Remove wakeup and clone cookbook (#2663) Modernize generated code for Hydrators (#2665) Add tests for introduction (#2664) doc: Review mapping ORM and ODM cookbook (#2658) doc: Review cookbook on blending ORM and ODM (#2656) doc: Review and test validation cookbook (#2662) Update custom mapping example (#2654) doc: Review Simple Search Engine Cookbook (#2659) doc: Add cookbook about embedding referenced documents using $lookup (#2655) doc: Add type to properties (#2652) doc: Review custom collections and repository docs (#2653) doc: Review Getting Started (#2650) Move annotations-reference to attributes-reference (#2651) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This cookbook was copied from the ORM but removed because the solution was not compatible with lazy ghost objects doctrine/orm#10187.
The examples are also far too abbreviated to show the use case and the complete solution.