Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add uncountable word from Laravel Framework #194

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Add uncountable word from Laravel Framework #194

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23dc0f6
Add uncountable word from Laravel Framework
cesarep Apr 8, 2022
d56c678
Removed non-nouns and added tests
cesarep Apr 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/Doctrine/Inflector/Rules/English/Uninflected.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ private static function getDefault(): iterable
yield new Pattern('butter');
yield new Pattern('cantus');
yield new Pattern('carp');
yield new Pattern('cattle');
yield new Pattern('chassis');
yield new Pattern('clippers');
yield new Pattern('clothing');
Expand Down Expand Up @@ -111,6 +112,7 @@ private static function getDefault(): iterable
yield new Pattern('jackanapes');
yield new Pattern('jeans');
yield new Pattern('jedi');
yield new Pattern('kin');
yield new Pattern('kiplingese');
yield new Pattern('knowledge');
yield new Pattern('kongoese');
Expand Down Expand Up @@ -149,6 +151,8 @@ private static function getDefault(): iterable
yield new Pattern('progress');
yield new Pattern('rabies');
yield new Pattern('rain');
yield new Pattern('recommended');
yield new Pattern('related');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these two aren't nouns, why are they being pluralized somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Laravel uses it, among other things, to determine the parameters name on a route, singularizing it, like: /images/{image}/, and table names for models, pluralizing it.
My guess is those are fairly common words to use in a URL, but to keep things consistent, maybe those should be handed there, and not here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That be the way to go in my opinion. Also please add tests for other 2 words that are to stay :)

yield new Pattern('research');
yield new Pattern('rhinoceros');
yield new Pattern('rice');
Expand Down