Add uncountable word from Laravel Framework #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malarzm
reviewed
Apr 8, 2022
| @@ -149,6 +151,8 @@ private static function getDefault(): iterable | |||
| yield new Pattern('progress'); | |||
| yield new Pattern('rabies'); | |||
| yield new Pattern('rain'); | |||
| yield new Pattern('recommended'); | |||
| yield new Pattern('related'); | |||
There was a problem hiding this comment.
these two aren't nouns, why are they being pluralized somewhere?
There was a problem hiding this comment.
Laravel uses it, among other things, to determine the parameters name on a route, singularizing it, like: /images/{image}/, and table names for models, pluralizing it.
My guess is those are fairly common words to use in a URL, but to keep things consistent, maybe those should be handed there, and not here
There was a problem hiding this comment.
That be the way to go in my opinion. Also please add tests for other 2 words that are to stay :)
|
Thanks @cesarep! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply adds uncountable words from Laravel not presented here:
'cattle', 'kin', 'recommended', 'related'