New driver: SQLite3 #5737
Merged
New driver: SQLite3 #5737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
feature/sqlite3
branch
2 times, most recently
from
ccf2cab to
446a822
Compare
morozov
reviewed
Oct 9, 2022
derrabus
force-pushed
the
feature/sqlite3
branch
3 times, most recently
from
46dc4b0 to
60aa8d3
Compare
derrabus
force-pushed
the
feature/sqlite3
branch
2 times, most recently
from
9297af3 to
2109049
Compare
morozov
reviewed
Oct 10, 2022
derrabus
force-pushed
the
feature/sqlite3
branch
from
2109049 to
4ee7efe
Compare
derrabus
force-pushed
the
feature/sqlite3
branch
2 times, most recently
from
30fe9e4 to
f97d946
Compare
morozov
reviewed
Oct 10, 2022
derrabus
force-pushed
the
feature/sqlite3
branch
from
f97d946 to
bd26e26
Compare
morozov
reviewed
Oct 10, 2022
derrabus
force-pushed
the
feature/sqlite3
branch
from
bd26e26 to
fdf0e4a
Compare
derrabus
force-pushed
the
feature/sqlite3
branch
from
fdf0e4a to
01bb5a7
Compare
morozov
approved these changes
Oct 10, 2022
|
Thank you for your very thorough review! ❤️ |
stof
reviewed
Oct 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces #840, #2264.
This PR adds a driver for
ext-sqlite3, allowing us to use SQLite without PDO.It is a bit unfortunate that we've mapped the URL scheme
sqlite3://to the PDO_SQLite driver via an alias.This is why I've introduced a new schemeAs discussed, theext-sqlite3://. On DBAL 4 where we've removed the aliases, we can change this back tosqlite3://. But I'm open for a better solution.sqlite3://URL scheme will work in DBAL 4, in DBAL 3 thedriverClassparameter has to be used for now.