Driver for SQLite3 #840
Driver for SQLite3 #840
Conversation
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1208 We use Jira to track the state of pull requests and the versions they got |
| @@ -49,6 +49,6 @@ public function getSQLDeclaration(array $fieldDeclaration, AbstractPlatform $pla | |||
| */ | |||
| public function convertToPHPValue($value, AbstractPlatform $platform) | |||
| { | |||
| return (null === $value) ? null : $value; | |||
| return (null === $value) ? null : (string) $value; | |||
There was a problem hiding this comment.
I had to modify this type because this test was still failing. This is because SQLite3 returns numeric values as float for numbers that can be represented as a floating-point value without loosing precision, and as string for others.
I'm not sure if this line should be updated or if the test should be modified instead, but I suppose this should be all right as the Decimal type is always supposed to return a string.
There was a problem hiding this comment.
You should fix this in the driver for now. It is a known problem that we do not like anything else then strings.
I think beberlei have some plans to fix it in the future. If we lucky someone will do it when they get annoyed enough by it :)
There was a problem hiding this comment.
I remove this change and the test passes. Not sure why. I'm going to branch and rebase this PR with this change reverted for now and see if the tests pass on travis.
There was a problem hiding this comment.
@zeroedin-bill That's weird, please keep me updated!
|
Any feedback on this PR? |
| /** | ||
| * @var array | ||
| */ | ||
| protected $_userDefinedFunctions = array( |
There was a problem hiding this comment.
no leading underscore and private visibility please.
There was a problem hiding this comment.
Sorry, just copy/pasted that from another driver. Fixed.
|
👍 when the underscore issue have been resolved |
|
Good for me! |
|
Ping @kimhemsoe , can this PR be merged? |
|
Ping @stof @kimhemsoe , what's preventing this PR from being merged, 7 months later? |
|
Hi guys, I've worked hard on this PR (and others), and it's a pity no one seems to care about them. |
|
@BenMorel I'm not a merger on the DBAL repo |
|
See #2264 |
This PR adds an additional driver using the SQLite3 class, in addition to the PDO_SQLITE driver.
Why this driver?
Even though the PDO SQLite driver is already available to interact with SQLite databases, PDO currently has a big limitation: it does not allow to load SQLite extensions.
This functionality is provided by the
SQLite3class, which becomes your only option if you need to use your PHP application with an SQLite extension such as SpatiaLite.