Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to doctrine/coding-standard 10 #5624

Merged
merged 2 commits into from
Aug 28, 2022
Merged

Conversation

greg0ire
Copy link
Member

This reverts commit 2393612.

@greg0ire greg0ire marked this pull request as ready for review August 28, 2022 13:41
@greg0ire greg0ire requested review from derrabus and morozov August 28, 2022 13:41
Copy link
Member

@morozov morozov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for the long strings, in some languages using concatenation to declare a long string in order to satisfy the coding standard is frowned upon since it makes the string harder to search in the code.

I'm curious if the standard could make an exception for such string (e.g. it's the only token on the line excluding whitespace and comma).

@greg0ire
Copy link
Member Author

For the record, I think we should use linebreaks in messages a bit more, one reason being it would make us feel a bit more free to write longer messages with more details. I don't know how the cs rule about line breaks is implemented, but I'd be surprised if it involved a parser.

Since the source code and the messages are both read by humans, it would make sense to make the messages legible by having linebreaks at some point. Using unindented nowdoc might allow having the same line length limit, except in situations where the message is used in an HTML without the linebreaks being transformed to <br/>. I'd be curious to know what presentation layers out there currently treat linebreaks.

@greg0ire greg0ire requested a review from morozov August 28, 2022 16:04
@greg0ire greg0ire merged commit a24b89d into doctrine:3.4.x Aug 28, 2022
@greg0ire greg0ire deleted the cs-update branch August 28, 2022 17:26
@greg0ire greg0ire added this to the 3.4.3 milestone Aug 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants