Skip to content

Commit

Permalink
Manually fix issues with lines that are too long.
Browse files Browse the repository at this point in the history
  • Loading branch information
greg0ire committed Aug 28, 2022
1 parent 35741d6 commit 3af0abc
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 8 deletions.
14 changes: 10 additions & 4 deletions src/Platforms/AbstractMySQLPlatform.php
Original file line number Diff line number Diff line change
Expand Up @@ -439,8 +439,11 @@ public function getCreateTablesSQL(array $tables): array
Deprecation::trigger(
'doctrine/dbal',
'https://github.com/doctrine/dbal/pull/5414',
'Relying on the DBAL not generating DDL for foreign keys on MySQL engines'
. ' other than InnoDB is deprecated. Define foreign key constraints only if they are necessary.',
<<<'DEPRECATION'
Relying on the DBAL not generating DDL for foreign keys on
MySQL engines other than InnoDB is deprecated.
Define foreign key constraints only if they are necessary.
DEPRECATION,
);
}
}
Expand Down Expand Up @@ -496,8 +499,11 @@ protected function _getCreateTableSQL($name, array $columns, array $options = []
Deprecation::trigger(
'doctrine/dbal',
'https://github.com/doctrine/dbal/pull/5414',
'Relying on the DBAL not generating DDL for foreign keys on MySQL engines'
. ' other than InnoDB is deprecated. Define foreign key constraints only if they are necessary.',
<<<'DEPRECATION'
Relying on the DBAL not generating DDL for foreign keys on
MySQL engines other than InnoDB is deprecated.
Define foreign key constraints only if they are necessary.
DEPRECATION,
);
}
}
Expand Down
3 changes: 2 additions & 1 deletion src/Statement.php
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,8 @@ public function execute($params = null): Result
Deprecation::triggerIfCalledFromOutside(
'doctrine/dbal',
'https://github.com/doctrine/dbal/pull/4580',
'Statement::execute() is deprecated, use Statement::executeQuery() or Statement::executeStatement() instead',
'%s() is deprecated, use Statement::executeQuery() or Statement::executeStatement() instead',
__METHOD__,
);

if ($params !== null) {
Expand Down
6 changes: 3 additions & 3 deletions tests/Functional/Schema/SchemaManagerFunctionalTestCase.php
Original file line number Diff line number Diff line change
Expand Up @@ -433,9 +433,9 @@ public function testDispatchEventWhenDatabasePlatformIsExplicitlyPassed(): void
public function testDiffListTableColumns(callable $comparatorFactory): void
{
if ($this->connection->getDatabasePlatform() instanceof OraclePlatform) {
self::markTestSkipped(
'Does not work with Oracle, since it cannot detect DateTime, Date and Time differences (at the moment).',
);
self::markTestSkipped(<<<'MSG'
Does not work with Oracle, since it cannot detect DateTime, Date and Time differences (at the moment).
MSG);
}

$offlineTable = $this->createListTableColumns();
Expand Down

0 comments on commit 3af0abc

Please sign in to comment.