Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make AbstractSchemaManager::_getPortableTableForeignKeyDefinition() abstract #5464

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Make AbstractSchemaManager::_getPortableTableForeignKeyDefinition() abstract #5464

merged 1 commit into from
Jun 21, 2022

Conversation

morozov
Copy link
Member

@morozov morozov commented Jun 21, 2022

This change is similar to #5456. It is possible to declare the method abstract as of #5457.

@morozov morozov added this to the 4.0.0 milestone Jun 21, 2022
@morozov morozov requested review from derrabus and greg0ire June 21, 2022 20:51
@morozov morozov merged commit a9187fe into doctrine:4.0.x Jun 21, 2022
@morozov morozov deleted the get-portable-foreign-key-definitione branch June 21, 2022 22:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@derrabus derrabus derrabus approved these changes

@greg0ire greg0ire Awaiting requested review from greg0ire

Assignees
No one assigned
Labels
BC Break Schema Management
Projects
None yet
Milestone
4.0.0-beta1
Development

Successfully merging this pull request may close these issues.
2 participants
@morozov @derrabus