Non-public API cleanup in AbstractSchemaManager #5456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atabaseDefinition()
derrabus
approved these changes
Jun 21, 2022
stof
reviewed
Jun 21, 2022
| @@ -780,10 +780,7 @@ protected function _getPortableTableDefinition(array $table): string | |||
| * | |||
| * @abstract | |||
There was a problem hiding this comment.
this @abstract should be removed now that it is natively abstract
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractSchemaManager::_getPortable*List()methods: they are invoked only from the correspondinglist*()methods and aren't overridden by any bundled implementations. Removing the rest of such methods requires additional changes and is out of scope._getPortable*Definition()methods should not have an implementation since their logic is platform-specific.filterAssetNames()method is now only used byAbstractSchemaManagerso it can be made private.