Remove support for transaction nesting without savepoints #5401
Conversation
greg0ire
force-pushed
the
mandatory-savepoints
branch
2 times, most recently
from
b7d772a to
c6fd2d5
Compare
| @@ -1045,39 +1039,37 @@ public function transactional(Closure $func): mixed | |||
| /** | |||
| * Sets if nested transactions should use savepoints. | |||
| * | |||
| * @deprecated No replacement planned | |||
| * | |||
| * @throws Exception | |||
| */ | |||
| public function setNestTransactionsWithSavepoints(bool $nestTransactionsWithSavepoints): void | |||
There was a problem hiding this comment.
If we keep the method, we should throw if false is passed.
There was a problem hiding this comment.
Why deprecate it in the next major given that the dummy mode is already deprecated and is being removed?
There was a problem hiding this comment.
In #5383, I tell people they should not call setNestTransactionsWithSavepoints(true) since false is the default for backward compatibility. If they do so, it means they will have one more action to perform right after upgrading to v4 before they have a working application. I'll leave you the judge of whether this is fine or not, I don't know if we should have some kind of rule about this. My concern is that if the list of such changes gets too big, the upgrade could become painful.
There was a problem hiding this comment.
I see, so there are two breaking changes necessary:
- Change the default mode from
falsetotruein 4.0 (we're letting users opt in to thetruemode in 3.x). - Remove the API for changing the mode in 5.0 (it will exist in 4.0 only as a stub for backward compatibility with 3.x).
Makes sense.
greg0ire
force-pushed
the
mandatory-savepoints
branch
from
78642ed to
81f04b3
Compare
greg0ire
force-pushed
the
mandatory-savepoints
branch
from
81f04b3 to
818b75c
Compare
No description provided.