Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate transaction nesting without savepoints #5383

Merged
merged 1 commit into from
May 7, 2022

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented May 7, 2022

When transaction nesting without savepoints is disabled, the behavior is
suprising: there is no inner transaction, and the outer transaction is
rolled back.
Users relying on a platform that does not support savepoints will have
to rework their application logic so as to avoid nested transaction
blocks.

@greg0ire greg0ire force-pushed the deprecate-dummy-transac-behavior branch 2 times, most recently from 3832bfc to 73e3db6 Compare May 7, 2022 12:30
When transaction nesting without savepoints is disabled, the behavior is
suprising: there is no inner transaction, and the outer transaction is
rolled back.
Users relying on a platform that does not support savepoints will have
to rework their application logic so as to avoid nested transaction
blocks.
@greg0ire greg0ire force-pushed the deprecate-dummy-transac-behavior branch from 73e3db6 to b1437af Compare May 7, 2022 12:38
@greg0ire greg0ire marked this pull request as ready for review May 7, 2022 12:47
@greg0ire greg0ire requested review from morozov and derrabus May 7, 2022 12:47
@greg0ire greg0ire added this to the 3.4.0 milestone May 7, 2022
@greg0ire greg0ire merged commit 2e957f7 into doctrine:3.4.x May 7, 2022
@greg0ire greg0ire deleted the deprecate-dummy-transac-behavior branch May 7, 2022 19:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants