Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-4503] Make OracleSchemaManager::dropAutoincrement() protected #4598

Merged
merged 1 commit into from
Apr 10, 2021
Merged

[GH-4503] Make OracleSchemaManager::dropAutoincrement() protected #4598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/Schema/OracleSchemaManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,11 +265,9 @@ public function createDatabase(string $database): void
}

/**
* @internal The method should be only used from within the OracleSchemaManager class hierarchy.
*
* @throws Exception
*/
public function dropAutoincrement(string $table): bool
protected function dropAutoincrement(string $table): bool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it also be made final or is it meant to be overridden ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d leave it as is for now. Making it final is out of scope, and there’s no problem if someone has it overridden. The issue is about public methods that require runtime assertions.

{
assert($this->_platform instanceof OraclePlatform);

Expand Down