[GH-4503] Make OracleSchemaManager::dropAutoincrement() protected #4598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Apr 10, 2021
| * @throws Exception | ||
| */ | ||
| public function dropAutoincrement(string $table): bool | ||
| protected function dropAutoincrement(string $table): bool |
There was a problem hiding this comment.
Should it also be made final or is it meant to be overridden ?
There was a problem hiding this comment.
I’d leave it as is for now. Making it final is out of scope, and there’s no problem if someone has it overridden. The issue is about public methods that require runtime assertions.
greg0ire
approved these changes
Apr 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4503.