Fix WriteTest for platforms supporting both sequences and identity columns #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-653 We use Jira to track the state of pull requests and the versions they got |
beberlei
added a commit
that referenced
this pull request
Nov 12, 2013
Fix WriteTest for platforms supporting both sequences and identity columns
deeky666
pushed a commit
that referenced
this pull request
Apr 30, 2015
Fixes #402 (doctrine/DoctrineBundle#402) by connecting by default to 'template1' instead of the database with the same name as the user (Postgre default in case of no dbname).
deeky666
pushed a commit
that referenced
this pull request
Apr 30, 2015
Fixes #402 (doctrine/DoctrineBundle#402) by connecting by default to 'template1' instead of the database with the same name as the user (Postgre default in case of no dbname).
This was referenced Dec 6, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
WriteTest::testLastInsertIdNoSequenceGiven()does not work if the tested platform supports both sequences and identity columns and when the driver is able to return distinguished information about the last inserted sequence ID and identity column ID.The problem here is that both sequence IDs and identity column IDs get inserted into the database in the tests before. Therefore a driver that is capable of distinguishing between last inserted sequence and identity column IDs returns the last inserted identity column ID when
Connection::lastInsertId(null)is called in this particular test.The behaviour of
Connection:lastInsertId()is very inconsistent throughout the drivers and therefore a true expectation can only be made if the tested platform supports sequences but not identity columns.