Can't drop PostgreSQL database

[davialexandre]

It started after commit 1ed0fec. When you try to connect to PostgreSQL without a dbname, the username is used instead. If you don't have a database with same name as the username the connection will fail (and if both, the username and the database that you're trying to drop, have the same name the drop will also fail).

After a few tests, I don't think this can be fixed in DropDatabaseDoctrineCommand. I think that maybe the solution would change Doctrine\DBAL\Driver\PDOPgSql\Driver::_constructPdoDsn to use some default database name (maybe postgres) if dbname isn't set, but I have no idea if this would impact somewhere else.

[phansys]

I opened a issue in PHP some time ago because I didn't know that this was the expected behavior.

[deeky666]

@davialexandre can we rely on postgres DB being always present? Is it possible to not have that DB in a server setup? I agree that we might need to add some abstraction around this issue to DBAL if it cannot be fixed this way...

[davialexandre]

@deeky666 The postgres database is always created by the initdb command, but it can be dropped. This command also creates the template1 database, that is a template for other databases. Templates cannot be dropped, so I believe it is a good candidate as a default database name

[steve-todorov]

@deeky666, @davialexandre is right. I've commented on your pull request a while ago with observations and a possible solution to this issue. The same approach is used in PhpPGAdmin and I haven't had any issues in the past 3-4 years or so.

Also, the documentation of PostgreSQL points out that you'll always have a template0 and template1 database (more here) so this approach should be safe to use.

[pdesgarets]

Same problem here. I agree to say that template1 is a good default database, and thus used it in my PR.

[steve-todorov]

Neat solution! @stof @deeky666 - whenever you have some time, could you please have a look at this and merge it if everything's ok? :)

[pdesgarets]

@steve-todorov I actually think that steve-todorov@113ebec is a better solution, as it deals with the unfortunate "feature" of PostgreSQL instead of hiding it through DBAL. Could you please rebase, create a specific branch and pull-request ? I will close my PR for dbal as soon as yours is opened for DoctrineBundle.

[deeky666]

@davialexandre @kiwidg @steve-todorov I merged the DBAL patch. Should be working with DBAL master now. Can someone confirm, please?
Also backported the fix to 2.5 and 2.4 branches.

[pdesgarets]

@deeky666 It works, for creating and dropping a database (with dev-master). Do you have an ETA for a v2.5.2 tag with the fix ?

[acasademont]

Yep, a 2.5.2 tag would come handy :D @deeky666

[trylika]

Ping again, release would really help

[deeky666]

Sorry guys didn't see the comments. Will tag a new version next week. Sorry for the delay

[Ph3nol]

Waiting for a 2.5.2 tag too. 👍
Thank you!

[deeky666]

New tag is available: https://github.com/doctrine/dbal/releases/tag/v2.5.2

[pdesgarets]

Thanks @deeky666 !

[kimhemsoe]

Reading from comments this issue should be solved with the tagging of a new dbal release, therefor i am closing this.