Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for PHP 7.2 #3900

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Drop support for PHP 7.2 #3900

merged 1 commit into from
Mar 17, 2020

Conversation

morozov
Copy link
Member

@morozov morozov commented Mar 17, 2020

Q A
Type improvement
BC Break no

Fixes #3899.

@morozov morozov added this to the 3.0.0 milestone Mar 17, 2020
@morozov
Copy link
Member Author

morozov commented Mar 17, 2020

Linking #2966 for the reference.

@morozov morozov linked an issue Mar 17, 2020 that may be closed by this pull request
Drop support for PHP 7.2 in DBAL 3.0 #3899
Closed
SenseException
SenseException approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval for this PR.

Are there any lines of code known to you that only exist because of 7.2 and that are in need to be updated? Just as an idea for follow-up PRs to this one.

@morozov
Copy link
Member Author

morozov commented Mar 17, 2020

Are there any lines of code known to you that only exist because of 7.2 and that are in need to be updated?

@SenseException none that I'm aware of. I searched the codebase for code like "7.2" and "702" and skimmed through the release notes.

@morozov morozov merged commit 02d3c61 into doctrine:3.0.x Mar 17, 2020
@morozov morozov deleted the issues/3899 branch March 17, 2020 14:37
@morozov morozov self-assigned this Mar 17, 2020
@morozov morozov removed this from the 3.0.0 milestone Sep 28, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SenseException SenseException SenseException approved these changes

@greg0ire greg0ire greg0ire approved these changes

@beberlei beberlei Awaiting requested review from beberlei

@lcobucci lcobucci Awaiting requested review from lcobucci

@Ocramius Ocramius Awaiting requested review from Ocramius

Assignees

@morozov morozov

Labels
CI Improvement PHP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop support for PHP 7.2 in DBAL 3.0
3 participants
@morozov @greg0ire @SenseException