Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require PHP 7.2, drop <7.2 in Composer & on CI #2966

Merged
merged 1 commit into from
Jan 6, 2018

Conversation

Majkl578
Copy link
Contributor

@Majkl578 Majkl578 commented Jan 5, 2018

Same reasons as in doctrine/orm#6529, but parameter type widening seems more important here.

@Ocramius Ocramius self-assigned this Jan 5, 2018
@Ocramius Ocramius added this to the 3.0.0 milestone Jan 5, 2018
@Ocramius
Copy link
Member

Ocramius commented Jan 5, 2018

@Majkl578 continuousphp pipeline requires updating too

@Majkl578
Copy link
Contributor Author

Majkl578 commented Jan 5, 2018

Yep I noticed, the build uses 7.1.11... They don't support 7.2 yet apparently: https://continuousphp.com/documentation/php/
I'll ping their support and see if there's any ETA.

@Pierozi
Copy link

Pierozi commented Jan 5, 2018

@Majkl578 I've release the container 7.2 few days ago, not yet documented you can select it by interface

@Majkl578
Copy link
Contributor Author

Majkl578 commented Jan 5, 2018

@Pierozi Thanks for the info, now that's the support I like. 👍
@Ocramius Can you try changing it here? I don't have permissions for that (can't change anything), thanks.

@Ocramius
Copy link
Member

Ocramius commented Jan 6, 2018

Updated, thanks a lot @Pierozi!

@Ocramius
Copy link
Member

Ocramius commented Jan 6, 2018

🚢

@Ocramius Ocramius merged commit 4adca54 into doctrine:develop Jan 6, 2018
@Majkl578 Majkl578 deleted the php-7.2 branch January 7, 2018 02:20
@morozov morozov modified the milestones: 4.0.0, 2.10.0 Nov 17, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants