Fix some whitelisted PHPStan errors #3822
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RunSqlCommandTest
is reworked to comply with its type constraints.Type
tests were reworked to test their respective classes w/o using the type registry (less coupling). Additionally, the platform mocks were reworked to mock the expected behavior explicitly instead of relying on the default platform logic (less coupling).Table::$_primaryKey = null
instead offalse
(the actual BC break).preg_replace()
error from the whitelist and added an assertion. Unless it's known under which circumstances a NULL may be returned (as pointed out in PHPStan is too strict about preg_replace() phpstan/phpstan#1901), we cannot test it. Hence, it's an assertion, not a condition with an exception.