Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove suppression for PHPStan errors fixing which in 2.x would be a BC break #3603

Closed
morozov opened this issue Jun 7, 2019 · 2 comments
Closed

Remove suppression for PHPStan errors fixing which in 2.x would be a BC break #3603

morozov opened this issue Jun 7, 2019 · 2 comments
Assignees
@morozov
Labels
Strict Typing
Milestone
4.0.0-beta1

Comments

@morozov
Copy link
Member

morozov commented Jun 7, 2019

Q A
BC Break no
Version 3.0

Something along these lines:

$ grep "BC break" phpstan.neon.dist 
        # removing it would be BC break
        # declaring $tableName in AbstractSchemaManager::_getPortableTableIndexesList() non-optional will be a BC break
        # changing these would be a BC break, to be done in next major
@morozov morozov added this to the 3.0.0 milestone Jun 7, 2019
@morozov morozov changed the title Remove suppression for PHPStan errors fixing which in master would be a BC break Remove suppression for PHPStan errors fixing which in 2.x would be a BC break Dec 31, 2019
@morozov morozov mentioned this issue Jan 16, 2020
Merged
@morozov morozov mentioned this issue Mar 16, 2020
Merged
@morozov morozov self-assigned this Mar 17, 2020
@morozov
Copy link
Member Author

morozov commented Mar 17, 2020

Closing as fixed by #3822 and #3896.

@morozov morozov closed this as completed Mar 17, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@morozov morozov

Labels
Strict Typing
Projects
None yet
Milestone
4.0.0-beta1
Development

No branches or pull requests
1 participant
@morozov