Enforced parameter and return value types in Connection classes #3568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
commented
May 30, 2019
| @@ -243,80 +243,4 @@ public function testGetParamsOverride() | |||
| 'host' => 'foo', | |||
| ], $conn->getParams()); | |||
| } | |||
|
|
|||
| public function testGetHostOverride() | |||
There was a problem hiding this comment.
The functionality of switching shards is still covered by the test above.
jwage
reviewed
May 30, 2019
jwage
reviewed
May 30, 2019
| * @param int[]|string[] $types The query parameter types. | ||
| * @param string $query The SQL query. | ||
| * @param array<int, mixed>|array<string, mixed> $params The prepared statement params. | ||
| * @param array<int, int|string>|array<string, int|string> $types The query parameter types. |
There was a problem hiding this comment.
Could this be written as array<int|string, int|string>?
There was a problem hiding this comment.
Not really. It's either an array with integer keys corresponding to parameter positions or an array with string keys corresponding to their names. Not a mix.
jwage
approved these changes
May 30, 2019
morozov
added a commit
to morozov/dbal
that referenced
this pull request
May 31, 2019
Enforced parameter and return value types in Connection classes
morozov
added a commit
to morozov/dbal
that referenced
this pull request
May 31, 2019
Enforced parameter and return value types in Connection classes
morozov
added a commit
to morozov/dbal
that referenced
this pull request
May 31, 2019
Enforced parameter and return value types in Connection classes
morozov
added a commit
to morozov/dbal
that referenced
this pull request
May 31, 2019
Enforced parameter and return value types in Connection classes
This was referenced Jun 2, 2019
morozov
added a commit
that referenced
this pull request
Jun 13, 2019
Enforced parameter and return value types in Connection classes
morozov
added a commit
that referenced
this pull request
Jun 27, 2019
Enforced parameter and return value types in Connection classes
morozov
added a commit
that referenced
this pull request
Jun 27, 2019
Enforced parameter and return value types in Connection classes
morozov
added a commit
that referenced
this pull request
Jun 27, 2019
Enforced parameter and return value types in Connection classes
morozov
added a commit
to morozov/dbal
that referenced
this pull request
Aug 26, 2019
Enforced parameter and return value types in Connection classes
morozov
added a commit
to morozov/dbal
that referenced
this pull request
Aug 26, 2019
Enforced parameter and return value types in Connection classes
morozov
added a commit
to morozov/dbal
that referenced
this pull request
Aug 26, 2019
Enforced parameter and return value types in Connection classes
morozov
added a commit
to morozov/dbal
that referenced
this pull request
Aug 27, 2019
Enforced parameter and return value types in Connection classes
morozov
added a commit
that referenced
this pull request
Nov 2, 2019
Enforced parameter and return value types in Connection classes
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
Connectionmethods, I'd like to be able to remove::getParams()as well in order to make connection parameters internal to the object and be able to modify them without introducing further BC breaks.DriverExceptionthrown byOCI8Connection::lastInsertId()because this method needs to be split apart: one for sequences, another for identity columns.