Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection::getParams() leaks implementation details #3593

Open
morozov opened this issue Jun 6, 2019 · 0 comments
Open

Connection::getParams() leaks implementation details #3593

morozov opened this issue Jun 6, 2019 · 0 comments

Comments

@morozov
Copy link
Member

morozov commented Jun 6, 2019

Q A
BC Break no
Version 2.9.3

The fact that the Connection::getParams() method exists makes it impossible to make any changes in the structure of the connection $params array w/o breaking the API. In #3568, we already removed ::getHost(), ::getPort(), ::getUsername() and ::getPassword().

We need to see if it's possible to get rid of the method entirely or at least reduce its usage and mark it as @internal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant