-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop db support for PostgreSQL 9.3 and MariaDB 10.0 #3477
Conversation
Should we then merge |
Sounds reasonable. I'll see that we keep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need a note in UPGRADE.md - you can expand the one already there from #3055.
Also please adjust information in the table in docs/en/reference/types.rst
At the end squashing into one commit would be 👌.
a640b82
to
e7b6c16
Compare
@SenseException are you planning to finish this or someone could take over? |
I forgot about this PR. The rebase will take a while, but I want to finish it. |
2ee696e
to
d02d411
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SenseException, looks good. Please squash.
9410d73
to
19fd578
Compare
My commits are now squashed. |
@SenseException can you confirm all commits are relevant to your ticket? As I can see, the first two are almost opposite to each other, ccf4a9d is about Please make sure only your changes are presented in the PR. I believe it should be a single commit since you were the only developer of this PR. |
19fd578
to
c7bedc5
Compare
c7bedc5
to
fee5873
Compare
Drop db support for PostgreSQL 9.3 and MariaDB 10.0
Drop db support for PostgreSQL 9.3 and MariaDB 10.0
Drop db support for PostgreSQL 9.3 and MariaDB 10.0
Drop db support for PostgreSQL 9.3 and MariaDB 10.0
Drop db support for PostgreSQL 9.3 and MariaDB 10.0
Drop db support for PostgreSQL 9.3 and MariaDB 10.0
Drop db support for PostgreSQL 9.3 and MariaDB 10.0
Drop db support for PostgreSQL 9.3 and MariaDB 10.0
Drop db support for PostgreSQL 9.3 and MariaDB 10.0
Summary
PostgreSQL 9.3 is an unsupported version since last year. MariaDB 10.0 support ends in March 2019 and considering that the next DBAL major release is still far in the future compared to MariaDB 10.0, I already removed it in this PR.