Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop db support for PostgreSQL 9.3 and MariaDB 10.0 #3477

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

SenseException
Copy link
Member

Q A
Type improvement
BC Break yes
Fixed issues -
Related #3055

Summary

PostgreSQL 9.3 is an unsupported version since last year. MariaDB 10.0 support ends in March 2019 and considering that the next DBAL major release is still far in the future compared to MariaDB 10.0, I already removed it in this PR.

@morozov
Copy link
Member

morozov commented Mar 4, 2019

Should we then merge PostgresqlPlatform and PostgreSQL94Platform?

@SenseException
Copy link
Member Author

Sounds reasonable. I'll see that we keep PostgresqlPlatform after the "merge".

Copy link
Contributor

@Majkl578 Majkl578 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a note in UPGRADE.md - you can expand the one already there from #3055.
Also please adjust information in the table in docs/en/reference/types.rst

At the end squashing into one commit would be 👌.

@morozov
Copy link
Member

morozov commented Jun 2, 2019

@SenseException are you planning to finish this or someone could take over?

@SenseException
Copy link
Member Author

I forgot about this PR. The rebase will take a while, but I want to finish it.

@SenseException SenseException force-pushed the drop-db-support branch 5 times, most recently from 2ee696e to d02d411 Compare June 9, 2019 20:50
Copy link
Member

@morozov morozov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SenseException, looks good. Please squash.

@SenseException
Copy link
Member Author

My commits are now squashed.

@morozov
Copy link
Member

morozov commented Jun 11, 2019

@SenseException can you confirm all commits are relevant to your ticket? As I can see, the first two are almost opposite to each other, ccf4a9d is about SQLLogger, etc.

Please make sure only your changes are presented in the PR. I believe it should be a single commit since you were the only developer of this PR.

@morozov morozov merged commit 86369fc into doctrine:develop Jun 14, 2019
morozov added a commit that referenced this pull request Jun 16, 2019
Drop db support for PostgreSQL 9.3 and MariaDB 10.0
morozov added a commit that referenced this pull request Jun 27, 2019
Drop db support for PostgreSQL 9.3 and MariaDB 10.0
morozov added a commit that referenced this pull request Jun 27, 2019
Drop db support for PostgreSQL 9.3 and MariaDB 10.0
morozov added a commit that referenced this pull request Jun 27, 2019
Drop db support for PostgreSQL 9.3 and MariaDB 10.0
morozov added a commit to morozov/dbal that referenced this pull request Aug 26, 2019
Drop db support for PostgreSQL 9.3 and MariaDB 10.0
morozov added a commit to morozov/dbal that referenced this pull request Aug 26, 2019
Drop db support for PostgreSQL 9.3 and MariaDB 10.0
morozov added a commit to morozov/dbal that referenced this pull request Aug 26, 2019
Drop db support for PostgreSQL 9.3 and MariaDB 10.0
morozov added a commit to morozov/dbal that referenced this pull request Aug 27, 2019
Drop db support for PostgreSQL 9.3 and MariaDB 10.0
morozov added a commit that referenced this pull request Nov 2, 2019
Drop db support for PostgreSQL 9.3 and MariaDB 10.0
@SenseException SenseException mentioned this pull request Feb 27, 2020
@morozov morozov modified the milestones: 4.0.0, 3.0.0 Mar 19, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants