Drop support for legacy platforms #3055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Majkl578
force-pushed
the
dev/drop-legacy-platforms
branch
3 times, most recently
from
62336a0 to
e59f616
Compare
Majkl578
force-pushed
the
dev/drop-legacy-platforms
branch
from
e59f616 to
a7f77ce
Compare
Majkl578
force-pushed
the
dev/drop-legacy-platforms
branch
from
a7f77ce to
dbdac39
Compare
Closed
morozov
reviewed
Mar 17, 2018
| 'datetime2' => 'datetime', | ||
| 'date' => 'date', | ||
| 'time' => 'time', | ||
| 'datetimeoffset' => 'datetimetz', |
There was a problem hiding this comment.
Would it make sense to have this sorted by key so that when you're looking for something, you don't have to use Ctrl + F?
There was a problem hiding this comment.
Done also for other platforms & keywords (separate commit).
| 'pgsql100' => PostgreSQL100Keywords::class, | ||
| 'oracle' => OracleKeywords::class, | ||
| 'db2' => DB2Keywords::class, | ||
| 'sqlanywhere' => SQLAnywhereKeywords::class, |
|
Changes:
|
Majkl578
force-pushed
the
dev/drop-legacy-platforms
branch
from
40acdb6 to
31146e9
Compare
Majkl578
commented
Mar 17, 2018
| 'AUDIT', | ||
| 'HAVING', | ||
| 'OFFLINE ', |
There was a problem hiding this comment.
Trailing space was a bug? Removed.
| 'AND', | ||
| 'FLOAT', | ||
| 'NOTFOUND ', |
There was a problem hiding this comment.
Trailing space was a bug? Removed.
| 'unsigned int' => 'integer', | ||
| 'numeric' => 'decimal', | ||
| 'smallint' => 'smallint', | ||
| 'unsigned smallint', 'smallint', |
There was a problem hiding this comment.
This was a bug - not a key-value mapping.
| 'smallint' => 'smallint', | ||
| 'unsigned smallint', 'smallint', | ||
| 'tinyint' => 'smallint', | ||
| 'unsigned tinyint', 'smallint', |
There was a problem hiding this comment.
This was a bug - not a key-value mapping.
morozov
approved these changes
Mar 17, 2018
Ocramius
approved these changes
Mar 18, 2018
This was referenced Mar 18, 2018
This was referenced Mar 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops:
closes #3052
closes #3053
closes #3054
closes #3058