Drop Doctrine\DBAL\Version in favor of Ocramius\PackageVersions #2967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
reviewed
Jan 5, 2018
composer.json
Outdated
| @@ -14,7 +14,8 @@ | |||
| "require": { | |||
| "php": "^7.1", | |||
| "ext-pdo": "*", | |||
| "doctrine/common": "^2.7.1" | |||
| "doctrine/common": "^2.7.1", | |||
| "ocramius/package-versions": "^1.2" | |||
There was a problem hiding this comment.
I know it's already merged into doctrine/doctrine2 but given the version is displayed in CLI to humans, would it make sense to use jean85/pretty-package-versions for prettier output?
There was a problem hiding this comment.
Eh, this is mostly so we can get proper reports when people get something wrong, so I think the human consumer is mostly @doctrine/doctrinecore
There was a problem hiding this comment.
Agreed, I would keep it simple and change if requested by users eventually, even now it's 2x more dependencies than before. 😃
Require PHP 7.2, drop <7.2 in Composer & on CI
Majkl578
force-pushed
the
dev/drop-version
branch
from
3dc98c6 to
686ac72
Compare
Ocramius
added a commit
that referenced
this pull request
Jan 29, 2018
…ons' into develop Close #2967
|
Manually merged via 2f085fc |
morozov
added a commit
that referenced
this pull request
Jan 30, 2020
Drop Doctrine\DBAL\Version in favor of Ocramius\PackageVersions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cross-linking doctrine/orm#6653