use namespace from traits #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,4 +10,29 @@ protected function getReader() | |||
| { | |||
| return new AnnotationReader(); | |||
| } | |||
|
|
|||
| public function testAnnotationFromTrait() | |||
| { | |||
There was a problem hiding this comment.
shoudln't you skip the test on 5.3 ?
|
This should also be supported for properties defined in traits |
|
@stof implemented propertyImports |
|
Please add a test with annotations on a property in a trait |
|
@stof test added. I'm glad you asked, found an error in the code because of the test ;) |
|
Looks good to me, but I don't have merge rights on this Doctrine repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Annotated Methods in Traits and is a follow up and replacement for PR #20
Annotations inside of Traits can use different Namespace than the including Class, see ClassUsesTrait.php in this PR for example.
As Methods of Traits can be overwritten, the Namespace of the actual class needs to be used.
Known Issue:
In the rare case of having the Trait and the Class defined in the same File and a method from Trait is overwritten in the Class and the namespace of an annotation differs than the namespace from the trait is used instead of the correct one from the class.