PhpParser does not parse use statements from traits.

[jaypea]

when parsing use statements from classes which use traits, the traits itself are not parsed.
this PR adds the missing trait parsing for php >= 5.4.
unit tests included.

[Ocramius]

Alignment and PSR-2 compliance

[Ocramius]

Looks good 👍

[stof]

this looks wrong to me: use statements of traits should only affect annotations set on properties and methods coming from the trait, not the whole class

[jaypea]

This would make sense, if ReflectionClass::getMethods() would make a difference on the origin of a method.
Since it does not and this PhpParser is part of the Annotation Parsing and is just used to build a lookup table of namespaces to be used by the DocParser it simply does not matter if the use statement was defined inside of a trait or the class itself.

[stof]

@jaypea If you have 2 annotation classes with the same short class name but in different namespaces, using one of them in the trait and the other one in the class itself will break in case you combine use statements.

[jaypea]

Yes, the behaviour is atleast undefined, it would use whichever of possible the Annotation classes.
To fix this, the complete library would need to be changed. The AnnotationReader Class is the only place to know the actual ReflectionMethod and needs to set the imports of the docParser based on the actual Trait.

btw: (ReflectionMethod->getFilename() !== ReflectionMethod->getDeclaringClass()->getFilename()) is the only way to check if a method was defined inside of a trait.

[jaypea]

@stof i've rewrote this and created a new PR at #22