Moving security-acl to an optional dependency #77
Conversation
|
I think there should be an additional check in DoctrineCacheExtension::loadAcl() then which throws an exception in case you try to configure the ACL cache without having installed the component (otherwise your application may break at runtime). |
|
@xabbuh Good idea - I've added a check for a key interface: if you try to configure acl without that interface present (which comes from |
|
Code sniffer fails. Otherwise 👍 |
|
Code sniffer fixed - should be ready for merge now. |
|
👍 (btw, not having 3.0.0-beta1 released is a bug in the release process imo, so it should be fixed soon as well) |
|
👍 |
|
Similar PR for symfony: symfony/symfony#16694 |
This PR was merged into the 3.0-dev branch. Discussion ---------- [SecurityBundle] make ACL an optional dependency | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | - Fixes #14718 (comment). Together with doctrine/DoctrineCacheBundle#77 we do not have ACL in the symfony-standard 3.0 by default anymore. Commits ------- fc66283 [SecurityBundle] make ACL an optional dependency
|
The PR on |
Moving security-acl to an optional dependency
|
Thanks @guilhermeblanco for the merge and the quick release :) |
This PR was merged into the 3.0-dev branch. Discussion ---------- remove security-acl from dependencies I guess it was just added in 82658ac to resolve unstable dependecies which should not be required anymore with doctrine/DoctrineCacheBundle#77 Commits ------- c54b1a5 remove security-acl from dependencies
Fixes #76
I believe symfony/security-acl isn't used by anything, but this bundle provides a cache layer for it (if you're using it).
This should also help doctrine/DoctrineBundle#486 (comment)
Thanks!