Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against different Symfony versions #486

Closed
wants to merge 2 commits into from

Conversation

wouterj
Copy link
Contributor

@wouterj wouterj commented Nov 9, 2015

This also tests the claim to support Symfony 3


install:
- if [ "$deps" = "no" ]; then composer install; fi;
- if [ "$deps" = "low" ]; then composer --prefer-lowest --prefer-stable update; fi;
- if [ "$deps" = "update" ]; then composer --prefer-dist update; fi;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for deps=update: we don't have a lock file in the repo, so install and update are doing the same already

@wouterj
Copy link
Contributor Author

wouterj commented Nov 9, 2015

On hold until doctrine/orm#1543 is merged and a new version is released

@weaverryan
Copy link
Contributor

@wouterj doctrine/orm#1543 was merged and is now part of 2.5.2. So, this can be pushed forward again, right?

@wouterj
Copy link
Contributor Author

wouterj commented Nov 25, 2015

Currently waiting for Security ACL 3.0.0-BETA1 to be released (seems to be forgotten).

@weaverryan
Copy link
Contributor

@wouterj I sent a pull request to make symfony/security-acl an optional dependency to the cache bundle: doctrine/DoctrineCacheBundle#76

@wouterj
Copy link
Contributor Author

wouterj commented Nov 27, 2015

Tests are green now, ready to be merged.

@weaverryan
Copy link
Contributor

👍

@xabbuh
Copy link
Member

xabbuh commented Nov 27, 2015

What about removing the job for PHP 5.6 without any special Symfony version? This would save one job per build.


env:
global:
- deps=no
- SYMFONY_DEPRECATIONS_HELPER=weak
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strict should be the default, and weak should be used for deps=low only

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@stof
Copy link
Member

stof commented Dec 5, 2015

Thank you @wouterj.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants