-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test against different Symfony versions #486
Conversation
|
||
install: | ||
- if [ "$deps" = "no" ]; then composer install; fi; | ||
- if [ "$deps" = "low" ]; then composer --prefer-lowest --prefer-stable update; fi; | ||
- if [ "$deps" = "update" ]; then composer --prefer-dist update; fi; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for deps=update
: we don't have a lock file in the repo, so install and update are doing the same already
On hold until doctrine/orm#1543 is merged and a new version is released |
@wouterj doctrine/orm#1543 was merged and is now part of 2.5.2. So, this can be pushed forward again, right? |
Currently waiting for Security ACL 3.0.0-BETA1 to be released (seems to be forgotten). |
@wouterj I sent a pull request to make symfony/security-acl an optional dependency to the cache bundle: doctrine/DoctrineCacheBundle#76 |
Tests are green now, ready to be merged. |
👍 |
What about removing the job for PHP 5.6 without any special Symfony version? This would save one job per build. |
|
||
env: | ||
global: | ||
- deps=no | ||
- SYMFONY_DEPRECATIONS_HELPER=weak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strict should be the default, and weak should be used for deps=low only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
Thank you @wouterj. |
This also tests the claim to support Symfony 3