fix: Update language support #1488
Conversation
Required to trigger auto-translate feature in applicable Chromium-based browsers (Chrome & Edge)
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/1stwj93rt |
jhildenbiddle
requested review from
sy-records and
a team
and removed request for
sy-records
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2626036:
|
|
It seems that the test snapshot file needs to be updated |
Co-authored-by: 沈唁 <[email protected]>
…s/docsify into update-language-support
@sy-records Yep. Good catch. I didn't test locally because I need the changes from #1487 to test on my ARM-based Mac. Should be all set now. |
Summary
Dynamically set the HTML
langattribute based on URL hash. This attribute must be set properly in order to trigger auto-translation features on applicable Chromium-based browsers (Chrome, Edge). Note that this fix works only for the initial page load aslangattribute changes are not recognized on hash change. For example:https://docsify.js.org/
https://docsify.js.org/#/zh-cn/
Remove the
write-a-plugin.mdalias as it appears to be unnecessaryAdd Russian and Spanish search-related label translations
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Before (notice the lack of the translation option in the URL bar)
After
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)