Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update most links to use https by default #13680

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Update most links to use https by default #13680

merged 1 commit into from
Oct 13, 2021

Conversation

PeterDaveHello
Copy link
Contributor

@PeterDaveHello PeterDaveHello commented Oct 12, 2021

Proposed changes

Update most links to use https by default for better security practice

Related issues (optional)

Reference:

- #11640
- d405b17

Signed-off-by: Peter Dave Hello <[email protected]>
@netlify
Copy link

netlify bot commented Oct 12, 2021

✔️ Deploy Preview for docsdocker ready!

🔨 Explore the source changes: ed135fe

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsdocker/deploys/61653d71b8366a000767858d

😎 Browse the preview: https://deploy-preview-13680--docsdocker.netlify.app

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Changes LGTM, but left a comment about some generated YAML files that were updated (which would also need to be updated in the upstream CLI repository to prevent the changes from being reverted at some point)

@@ -6,7 +6,7 @@ long: |-
By default, this renders all results in a JSON array. If a format is specified,
the given template will be executed for each result.

Go's [text/template](http://golang.org/pkg/text/template/) package
Go's [text/template](https://golang.org/pkg/text/template/) package
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The YAML files in the _data/engine-cli directory are generated from MarkDown source files in the CLI repository. For example, this page is generated from https://github.com/docker/cli/blob/master/docs/reference/commandline/config_inspect.md

So changes made in these YAML files will be overwritten when these files are regenerated and updated. Perhaps you're interested in opening a pull request with these changes in the CLI repository? https://github.com/docker/cli

When doing so, be sure to include a DCO sign-off line (Signed-Off-By) line in the commit message (see https://github.com/docker/cli/blob/master/CONTRIBUTING.md#sign-your-work), otherwise CI will fail in that repository.

I'm also happy to make those changes if you want

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see you're already using a DCO for your commits, so you probably don't need the instructions 😂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I'll take a look at docker/cli, thanks.

@thaJeztah thaJeztah merged commit 7a0726a into docker:master Oct 13, 2021
PeterDaveHello added a commit to PeterDaveHelloKitchen/cli that referenced this pull request Oct 15, 2021
thaJeztah pushed a commit to thaJeztah/cli that referenced this pull request Oct 15, 2021
cc @thaJeztah docker/docs#13680

Signed-off-by: Peter Dave Hello <[email protected]>
(cherry picked from commit 417f976)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this pull request Oct 15, 2021
cc @thaJeztah docker/docs#13680

Signed-off-by: Peter Dave Hello <[email protected]>
Upstream-commit: 417f97605f547a44d721225c26a9bdbf2600a991
Component: cli
crazy-max pushed a commit to crazy-max/buildkit that referenced this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants